Apache OpenOffice (AOO) Bugzilla – Issue 104727
patch for dmake to properly work if installed in a dir spaces in its name
Last modified: 2017-05-20 09:37:58 UTC
Hi, please find a patch for dmake utility from here: http://svn.ali.as/cpan/users/kmx/dmake_patch/dmake_svn-rev275670_patch.diff The patch contains fixes for this: 1) dmake is not able even start if it is installed in a directory containing spaces in directory name. - I have to fix dmake itself (4-line patch of expand.c) - but also startup/*.mk scripts (I have fixed just Windows related files) - you might want to patch other (e.g. unix) *.mk files in a similar way 2) I have added a build batch for mingw32 enviroment - see newly added winnt/mingw/build.cmd + winnt/mingw/config.h Please consider the patch, it would be nice if you can accept it an commit in your SVN as we are using dmake in strawberry perl project (http://www.strawberryperl.com) and do not want to keep any sort of unofficial dmake patches. Thanks -- kmx
Hi, could you please give me some feedback to the proposed patch. If you do not like anything included in my patch I'll be happy to fix it or help you in other way. The most important part is a patch for expand.c + startup/*.mk files as it is a blocker for using dmake from directory which name contains spaces. Thanks. -- kmx
sorry, must have missed that one completely. the patch look fine on first glance. i'll have a closer look soon. don't hesitate to ping me as dmake changes aren't my current focus. meanwhile please check out http://wiki.services.openoffice.org/wiki/Contributing_Patches , especially the first paragraph.
> meanwhile please check out > http://wiki.services.openoffice.org/wiki/Contributing_Patches , > especially the first paragraph. Well, you mean I have to sign the agreement? To be honest I do not have any ambitions to participate in OpenOffice development process. I have just this veeery simple patch to dmake tool and I promise this is my last patch, I am not gonna submit any other. If you consider anything in my very simple patch a intellectual property I declare that I have coded it myself, it is absolutely patent-free and you or anybody else can release it under whatever licence you want. We (strawberry perl project) are going to do a major binaries rebuild for January-2010 release (incl. dmake) and it would be nice to have at least the patch for expand.c + startup/*.mk in the latest SVN trunk version. Thanks. -- kmx
I have updated the previously submitted patch a little bit - see: http://svn.ali.as/cpan/users/kmx/dmake_patch/dmake_svn-rev277396_patch.diff The previous (not so good) patch removed. -- kmx
Bad news, my patch does not work well with the following Makefile: ######### LIST1 = a.a ../b.b ./c.c ..\d.d .\e.e /f.f \g.g c:/h/h.h c:\i\i.i LIST2 = $(LIST1:f) all: echo "LIST2=$(LIST2)" ######### At the moment I have no idea how to fix it. I would appreciate any help. -- kmx
I copied this to the new project "home": http://code.google.com/a/apache-extras.org/p/dmake/