Apache OpenOffice (AOO) Bugzilla – Full Text Issue Listing |
Summary: | ooo1.0 ppc linux bridge code in OOO_STABLE_1 is old | ||||||
---|---|---|---|---|---|---|---|
Product: | udk | Reporter: | khendricks | ||||
Component: | code | Assignee: | khendricks | ||||
Status: | CLOSED FIXED | QA Contact: | issues@udk <issues> | ||||
Severity: | Trivial | ||||||
Priority: | P3 | CC: | issues, joergbudi, nesshof, openoffice | ||||
Version: | current | ||||||
Target Milestone: | --- | ||||||
Hardware: | Mac | ||||||
OS: | Linux, all | ||||||
Issue Type: | DEFECT | Latest Confirmation in: | --- | ||||
Developer Difficulty: | --- | ||||||
Attachments: |
|
Description
khendricks
2002-02-19 01:53:06 UTC
Created attachment 1058 [details]
patch to update bridge/source/cpp_uno/gcc2_linux_powerpc to OO641C level
Daniel, could you please approve this patch? It will then be applied by Kevin and goes into OOo stable build. I trust your code, Kevin and cannot approve this issue, anyway. We don't have any linux power-pc machine here in Hamburg. So as long as this does not stop our internal builds (correct .IF statements in makefile.mk), you have to test this by yourself. And I am sure you have already done while developing... usual tests: compile the testcppu executable in cppu/test directory and run it. For more high-level office specific testing, try some basic stuff (basic using corereflection using bridges). adding proper ooo1.0 keyword I should have put there first reassigned to joerg ok, I was too fast, first think then type Hi, In case this helps. This exact patch was in OO641C and in many other earlier release builds. I konw because I had commit privs to the ppc Linux specific part of the bridge code (which this is). It ONLY impacts the PPC Linux platform code and will not impact any other platform. Hope this helps, Kevin Hi, Any ruling on this patch yet. I promise you it will not impact the build and has been in Oo641C and many earlier versions and only impact the ppc linux bridge code which I wrote based on the x86 bridge code and lots of helpful hints from Hamburg. Without this patch, the bridge code simply will not work and OOo can then not be used under ppc linux. Please someone allow me to commit this patch. Thanks, Kevin I think Daniel wanted to say that he always trust your code in this LinuxPPC dependent directory and is not able to test this. From my point of view you don't need approval for this directory and daniel (dbo@openoffice.org) will give advise for any bridges code whenever he is able to. Daniel, can you please give a statement to my assumption ? Yes Martin, that's what I wanted to say: @Kevin: Please check in your bridges linux ppc changes. I trust you. Just wanted to point out that, nevertheless, I can't review/test it nor is this necessary for our target platforms. regards, --Daniel Hi All, Thanks! I just did the commit to OOO_STABLE_1 so ppc linux is in good shape now in bridges. Thanks again! Kevin closing this one out. |