Apache OpenOffice (AOO) Bugzilla – Full Text Issue Listing |
Summary: | "defined" not allowed in file names | ||
---|---|---|---|
Product: | Build Tools | Reporter: | daniel.rentz |
Component: | dmake | Assignee: | quetschke |
Status: | CLOSED FIXED | QA Contact: | issues@tools <issues> |
Severity: | Trivial | ||
Priority: | P3 | CC: | hans-joachim.lankenau, issues |
Version: | 680m213 | ||
Target Milestone: | --- | ||
Hardware: | All | ||
OS: | All | ||
Issue Type: | DEFECT | Latest Confirmation in: | --- |
Developer Difficulty: | --- |
Description
daniel.rentz
2007-07-04 10:40:55 UTC
This must be some legacy code. As dmake nowhere mentions ".IF defined()" id does not need to error on them, maybe a warning, but even that is not needed. The next dmake version will remove this error, until then something like this works around this bug: +++ solenv/inc/target.mk 4 Jul 2007 21:40:58 -0000 @@ -105,7 +105,7 @@ .ENDIF # "$(L10N_framework)"=="" DEPFILES:=$(uniq $(DEPFILESx)) DEPCOLLECT_SLO!:=$(uniq $(DEPCOLLECT_SLO)) -.IF "$(DEPCOLLECT_SLO)"!="" +.IF "x$(DEPCOLLECT_SLO)"!="x" DEPFILE_SLO+:=$(MISC)$/all_$(TARGET).dpslo .ENDIF # "$(DEPCOLLECT_SLO)"!="" DEPCOLLECT_OBJ!:=$(uniq $(DEPCOLLECT_OBJ)) @ause: Maybe you can sneak this workaround into somewhere, dmake411 will fix this for good. This workaround does not work. Anyway, if I comment out the ".IF" in line 108, it will fail in lines 240, 276, 1305, 1682, 1687, 1888 again. Any reason why it doesn't work? Error message? And the lines 240, 276, 1305, 1682, 1687, 1888 would most probably need the same workaround. OOo 2.4 will have a fixed dmake. I have tried the patch, it resulted in the very same error message as described above. Maybe the reason is that the file containing "defined" is *not* the first entry in the SLOFILES variable. Will try your patch again with moving the file name to the top of the list... No, this does not help, maybe because $(uniq ...) sorts the entries in the variable or whatever. I'm sorry, my patch cannot work. I just checked that dmake is looking for the "defined" anywhere in the string after the .IF. So putting the "x" there doesn't help. Sorry, will be fixed in the next dmake. :( Fixed in cws_src680_dmake411. ok . |