Issue 101360 - docbook: use xsl:element for element construction
Summary: docbook: use xsl:element for element construction
Status: CLOSED FIXED
Alias: None
Product: xml
Classification: Code
Component: external filters (show other issues)
Version: DEV300m46
Hardware: All All
: P5 (lowest) Trivial (vote)
Target Milestone: 3.4.1
Assignee: dtardon
QA Contact: issues@xml
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-04-27 09:29 UTC by dtardon
Modified: 2017-05-20 09:30 UTC (History)
2 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
proper construction of XML elements (5.79 KB, patch)
2009-04-27 09:31 UTC, dtardon 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description dtardon 2009-04-27 09:29:23 UTC 
There is several instances of use xsl:text for constructing an element and one
instance for constructing an attribute in
filter/source/docbook/sofftodocbookheadings.xsl. I think that is vile and anyone
doing it should be shot at dawn (or be subjected to some torture, at least :).
I'm attaching a patch to replace them by xsl:element/xsl:attribute, with one
exception--construction of tgroup element in template matching
table:table/table:table-row--that would require refactoring of the existing code.
Comment 1 dtardon 2009-04-27 09:31:14 UTC 
Created attachment 61834 [details]
proper construction of XML elements
Comment 2 mst.ooo 2010-12-22 22:28:00 UTC 
eeeeeeeewww, WTF???

i second the motion for corporal punishment in this case.

thanks for the patch dtardon!

fixed in CWS sw34bf03
http://hg.services.openoffice.org/hg/cws/sw34bf03/rev/d502e3de2644
Comment 3 mst.ooo 2010-12-22 22:30:49 UTC 
please verify
Comment 4 dtardon 2010-12-23 07:17:58 UTC 
verified