Issue 105504 - Build fails on calling msitran.exe
Summary: Build fails on calling msitran.exe
Status: ACCEPTED
Alias: None
Product: Build Tools
Classification: Code
Component: solenv (show other issues)
Version: OOo 3.1.1
Hardware: PC Windows, all
: P3 Trivial (vote)
Target Milestone: ---
Assignee: AOO issues mailing list
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-01 09:44 UTC by pavel.lastovicka
Modified: 2013-08-07 15:34 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description pavel.lastovicka 2009-10-01 09:44:32 UTC
Windows build fails during packaging for certain languages.
The bug is in the file solenv/bin/modules/installer/windows/msiglobal.pm
in the sub create_transforms(). The code there checks for a "problematic"
version of msitran.exe. 
  But as far as I know, the msitran.exe is not problematic. Instead it returns
return code of 1 on success, in program version 4. So the OO.o code should check
for msitran.exe version first and then interpret its return code accordingly.
Comment 1 pavel.lastovicka 2009-10-01 09:56:13 UTC
Note: using checksums is neither clever or reliable way of determining program
version. Although I have msitran.exe 4.0.6000.16384, it has different checksum
than the two sums specified in the source code.
Comment 2 ingo.schmidt-rosbiegal 2009-10-07 10:50:14 UTC
We have had problems with some versions of msitran.exe. Checksum was the only
way to detect the version reliable. 
Why breaks your Windows build? Do you have an error message or the log file from
the packaging process?
Comment 3 pavel.lastovicka 2009-10-07 17:25:46 UTC
I don't have the logfile but error messages that showed during building are
contained in the source code. Build failed because my msitran.exe returned 1 and
its checksum was not the same as the checksums in the msiglobal.pm.
Error messages were the following (from the source code):
  WARNING: Returnvalue of $msitran is not 0. Checking version of $msitran!
  This is not a problematic version of msitran.exe. Therefore the error is not
caused by problematic msitran.exe.
Comment 4 ingo.schmidt-rosbiegal 2009-10-28 14:45:07 UTC
I will investigate this.
Comment 5 ingo.schmidt-rosbiegal 2010-02-10 11:29:20 UTC
Setting target 3.x
Comment 6 pavel.lastovicka 2010-08-28 15:46:52 UTC
is: Hello, has there been any progress on this? The issue is marked started.
Comment 7 ingo.schmidt-rosbiegal 2010-09-01 15:45:13 UTC
No progress yet.