Issue 106448 - oox: make formula strict-aliasing warning safe
Summary: oox: make formula strict-aliasing warning safe
Status: CLOSED FIXED
Alias: None
Product: xml
Classification: Code
Component: code (show other issues)
Version: DEV300m63
Hardware: All Linux, all
: P3 Trivial (vote)
Target Milestone: OOo 3.3
Assignee: daniel.rentz
QA Contact: issues@xml
URL:
Keywords:
Depends on:
Blocks: 101100
  Show dependency tree
 
Reported: 2009-10-29 18:01 UTC by caolanm
Modified: 2010-07-27 10:56 UTC (History)
1 user (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
patch to do this (1.34 KB, patch)
2009-10-29 18:01 UTC, caolanm 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description caolanm 2009-10-29 18:01:24 UTC 
To facilitate removing -fno-strict-aliasing we'd have to avoid making direct
casts between unrelated types. Attached is a fix for oox to allow that.
(e.g. see issue 106384 for similar)
Comment 1 caolanm 2009-10-29 18:01:50 UTC 
Created attachment 65770 [details]
patch to do this
Comment 2 daniel.rentz 2009-10-29 18:54:14 UTC 
started
Comment 3 daniel.rentz 2009-10-29 19:04:19 UTC 
dr->cmc: I wonder that you didn't change the usage of reinterpret_cast in the
function lclCalcRkFromDouble() in the same file?
Comment 4 daniel.rentz 2009-10-29 19:31:24 UTC 
fixed in DEV300/dr74
Comment 5 caolanm 2009-10-29 21:35:58 UTC 
the ways of gcc and aliasing are mysterious. gcc probably doesn't warn as
there's no write through the aliased pointer
Comment 6 daniel.rentz 2010-01-18 12:46:38 UTC 
internal code change, verified
Comment 7 daniel.rentz 2010-07-27 10:56:12 UTC 
closing