Issue 107504 - xmloff: suspicious variable declarations
Summary: xmloff: suspicious variable declarations
Status: CLOSED FIXED
Alias: None
Product: xml
Classification: Code
Component: code (show other issues)
Version: DEV300m66
Hardware: All All
: P5 (lowest) Trivial (vote)
Target Milestone: OOo 3.3
Assignee: caolanm
QA Contact: issues@xml
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-07 17:39 UTC by dtardon
Modified: 2010-05-22 17:32 UTC (History)
1 user (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
remove the variables (415 bytes, patch)
2009-12-07 17:40 UTC, dtardon 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description dtardon 2009-12-07 17:39:56 UTC 
There are four global variables declared in
xmloff/source/style/XMLRectangleMembersHandler.cxx:54 . Seeing they neither are
used in that file nor declared as extern in any header, they were probably
pasted there by a mistake. The attached patch removes them.
Comment 1 dtardon 2009-12-07 17:40:48 UTC 
Created attachment 66540 [details]
remove the variables
Comment 2 dtardon 2009-12-07 17:42:39 UTC 
i'll take this
Comment 3 dtardon 2009-12-07 17:43:14 UTC 
accepting
Comment 4 dtardon 2009-12-07 17:51:55 UTC 
done in CWS dtardon01, changeset c30c51cafbcf
Comment 5 dtardon 2010-04-07 14:12:18 UTC 
reassigned for verification
Comment 6 caolanm 2010-04-07 20:32:00 UTC 
verified
Comment 7 caolanm 2010-05-22 17:32:51 UTC 
closed, integrated DEV300_m78