Issue 108952 - add to custom show list ,then hide all pages at custom show ,finally play it ,program crash
Summary: add to custom show list ,then hide all pages at custom show ,finally play it ...
Status: CONFIRMED
Alias: None
Product: Impress
Classification: Application
Component: code (show other issues)
Version: OOO320m9
Hardware: All All
: P2 Trivial (vote)
Target Milestone: ---
Assignee: AOO issues mailing list
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-04 12:45 UTC by yujinliang
Modified: 2018-07-09 13:41 UTC (History)
6 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
a patch file for fix this bug (3.46 KB, text/plain)
2010-02-04 12:54 UTC, yujinliang
no flags Details
a new patch file (3.88 KB, text/plain)
2010-02-08 13:50 UTC, yujinliang
no flags Details
Just Click "Slide Show" or Press F5 to terminate the Impress (10.48 KB, application/vnd.oasis.opendocument.presentation)
2011-02-19 22:19 UTC, ziohausam
no flags Details

Note You need to log in before you can comment on or make changes to this issue.
Description yujinliang 2010-02-04 12:45:16 UTC
[Steps]
1. Create a new impress document, in which create some pages.
2. Select Menu: Presentation - Custom Show, in the pop-up "Custom Show dialog",
click the "New button", pop-up "Define Custom Show dialog".
3. Select one or more  pages and  click "Double Arrow
button" added to the "custom show list" ,then click "Ok button"
4. check the "use custom show checkbox" .
5. In the thumbnail box(slidesorter) select  one or more pages, which has been
added to "custom show list " , right-click , popup a menu then select
"menu-hidden slides".
[result] if you  play the "custom show list" then the program to crash.
Comment 1 yujinliang 2010-02-04 12:52:22 UTC
I think if one or more pages has been added to "custom show list", which were
not allowed to hide !so if that ,should disable the "Play Slides" 
Comment 2 yujinliang 2010-02-04 12:54:54 UTC
Created attachment 67608 [details]
a patch file for fix this bug
Comment 3 yujinliang 2010-02-04 12:58:04 UTC
I have fixed it !
Comment 4 yujinliang 2010-02-04 13:01:30 UTC
create patch file based on http://svn.services.openoffice.org/ooo/trunk
version:277955
Comment 5 yujinliang 2010-02-08 13:02:51 UTC
Sorry, the previous bug description have some wrong, at step 5. Now correct it!

step 5: append a sentence, that is: hide all pages at current custom show!
Comment 6 yujinliang 2010-02-08 13:07:09 UTC
if all pages were hidden at current custom show, then should disable play slide!
so , i rewrite my code for it ! please see new patch file!
Comment 7 yujinliang 2010-02-08 13:50:13 UTC
Created attachment 67707 [details]
a new patch file
Comment 8 Martin Hollmichel 2010-06-24 09:41:06 UTC
is this still a valid issue ?
Comment 9 clippka 2010-06-24 10:33:39 UTC
I will have a look

cl->yujinliang: ist this patch is already applied to a childworkspace? If not
please do not set it as resolved fixed as only open issues will get noticed and
added
Comment 10 clippka 2010-06-24 10:34:07 UTC
reopening so I can see this issue in my list
Comment 11 rajlbel 2010-09-03 18:05:17 UTC
OS: Windows XP & Windows 7
Open Office used: 3.2.1 Stable version, 3.3.0 Beta, and DEV300m87 (OOo-Dev 3.x)

Summary: Playing a Custom Slide Show with hidden slides only crashes program

Able to replicate the bug following the steps:

1. Create new impress presentation
2. Add 1 or more new slide(s)
3. Select any slide(s), right-click and select "Hide Slide"
Note: if you select all slides to hide, the play slide show will be disabled. 
Therefore, leave at least one slide as unhidden.
4. Under "Slide Show" menu, select "Custom Slide Show...", and then "Custom 
Slide Shows" pop-up will appear
5. In pop-up, click "New...", and then "Define Custom Slide Show" pop-up will 
appear
6. Add only the hidden slide(s) from the "Existing slides" box to the "Selected 
slides" box by clicking the ">>" button. Click OK
7. In "Custom Slide Show" pop-up, check "Use Custom Slide Show".
8. Click "Start" button in "Custom Slide Show" pop-up


Doing follow-up test varying how to playing the slide show...
Variation 1:
1. Do steps 1 - 7 from above.
2. Click "Close" button in "Custom Slide Show" pop-up.
3. Press F5 from keyboard.

Variation 2:
1. Do steps 1 - 7 from above.
2. Click "Close" button in "Custom Slide Show" pop-up.
3. On the "Tasks" sidebar, select "Slide Transition". Click "Slide Show" button.

Program still crashes with the previous variations. The "play slide" is not 
disabled if the custom slide show only includes hidden slide(s). But it does 
disable if all the slides are hidden.


Tested Original steps with Microsoft PowerPoint 2007 & 2003
The program played the custom slide show with hidden slides only. 
Comment 12 Martin Hollmichel 2011-02-17 19:38:43 UTC
move away from 3.4 target.
Comment 13 ziohausam 2011-02-19 22:15:27 UTC
(Hossam, 02/19/2011)
Issue is reproducible with Impress version OOo-dev 3.4.0 DEV300m99 (Build:9570) 
using the following configuration:
1- 32 Bit Windows 7
2- Dell Laptop Latitude E5500
3- Processor: Intel(R) Core(TM)2Due CPU 2.00 GHz
4- RAM: 3.00 GB

Description Summary: Impress immediately terminates when playing a custom slide 
show with all slides in this custom slide show are hidden.

Steps:
1- Create a new impress document
2- Create at least 1 slide
3- Select Menu: Slide show --> Custom Slide Show: "Custom Slide Show" dialogue 
box appears
4- Click New Button: "Define Custom Slide Show" dialogue box appears
5- Select a slide or more from the left side list and click the ">>" button to 
add the slides to the right side list
6- Click Ok, you will be back to "Custom Slide show" dialogue 
7- Check "Use custom slide show"
8- Click "Close"
9- In the main stage, click "Slide Sorter" tab
10- Select all slides you have added to the custom slide show and Right click --
> Hide Slide
11- Now press F5 or click "Slide Show" button

Program terminates/Crashes

I will attach an odp document that you just open and click "slide show" or press 
F5 to terminate the Impress
Comment 14 ziohausam 2011-02-19 22:19:02 UTC
Created attachment 75882 [details]
Just Click "Slide Show" or Press F5 to terminate the Impress
Comment 15 ziohausam 2011-02-19 22:40:13 UTC
Issue scenario occurrence is possible. It might not be easy, however it is still 
possible. There are 2 situations that I think we should consider:

1- One problem that a user might face, is the "not saved work". He will be 
depending on the recovery process which might not go OK for any reason.

2- Also in presentation time, when the presenter for any reason decides to hide 
the Custom Slide show slides and just work with other slides, If he forgets to 
uncheck the "Use Custom Slide Show" check box, the program will terminate
Comment 16 ziohausam 2011-02-19 22:46:46 UTC
Please Note: If you are not using custom slide show, and hiding all slides in the 
main slide show, No problems occurs when running the show using F5 or "Slide Show" 
button. This problem occurs only with custom slide shows
Comment 17 mgaertne 2012-06-15 20:54:42 UTC
I was able to reproduce the bug on this configuration:
Apple Mac OS X Version 10.7.4
2.66 GHz Intel Core i7, 8GB Memory
OpenOffice.org Version 3.4.0 (AOO340m1 (Build 9590)) - Rev. 1327774

I tried to use the reproduction steps from the initial comment. With the hints from comment 11. I won't repeat them here.

I was able to reproduce the issue several times. Here are the critical steps that I identified:
1. Create a new presentation or open/import an existing one.
2. Make sure you have at least two slides in your presentation.
3. Hide one of the slides (using the menu, the slide sorter or the icon while hovering over does not matter).
4. Navigate to menu "Slide Show" -> "Custom Slide Show"
5. Create a new "Custom Slide Show", put just the hidden slide in there, and check the box to use the custom slide show.
6. Start the presentation (via Start in the Custom Slide Show dialog, via F5 or via any other mechanism does not matter).

The screen flashed for me to black for a fraction of a second, then OpenOffice.org Impress crashed.

Based on the follow-up tests that I ran the critical conditions seem to be that you have all slides in your custom slide show hidden, and you have at least one unhidden slide that is not part of the custom slide show. This will enable keyboard shortcut F5 to start the presentation. This action then probably does not find any slide that it can display, and makes the application crash. This is my interpretation of the blinking black screen that I noticed while coming up with follow-up tests.

I could not reproduce the crash when I had all slides set to hidden in the presentation as the F5 shortcut was then disabled and I could not start the presentation at all. I suspect a dependency on whether or not the menu item/shortcut (F5) is disabled. I think the validation for disabling the menu item does not include custom slide shows.

Regarding the business impact, from time to time I am myself a conference presenter. As such, I think that I wouldn't run custom slide shows with all hidden slides too often. This could be a mis-use of the application, but a user could accidentally run into this condition, and the application at that point should not crash, as unsaved changes will be lost afterwards, even after recovering the data during the next startup.

I suggest to change the bug summary line the following:
“Presenting a custom slide show with all slides hidden crashes Impress”

I recorded my actions and uploaded them to youtube while I was on my Mac. You can see the two videos here:
- http://youtu.be/gTfMo71gHoU
- http://youtu.be/33QCNkf-qS4
Comment 18 Rob Weir 2013-07-30 02:45:44 UTC
Reset assignee on issues not touched by assignee in more than 1000 days.
Comment 19 jkfidel 2013-11-14 18:25:56 UTC
This bug can still be reproduced in a current build.  I have used the following configuration:
Apache OpenOffice 4.0.1; AOO401m5(Build:9714)  -  Rev. 1524958
Windows 7 Ultimate 64-bit, Service Pack 1
Intel Core 2 Duo T6600 2.20 GHz, 4GB RAM

Test 1
Set-up:
The instructions in Comment 17 are spot-on.  I did not find a simpler means of replication.
Result:
The screen flashes black for an instant, I briefly notice a blank dialog box, and Impress crashes.

Some follow-up tests...

Test 2
Set-up:
1. New empty presentation.
2. Create just one slide.
3. Slide Show -> Hide Slide OR Click Hide-Slide button under Slide Pane sidebar
4. Play slide show via...
  a. F5 -> no result, as expected
  b. Slide Show -> Slide Show is disabled, as expected
Result:
Functionality is as expected; the slide show does not start because the only slide is hidden.

Test 3
Set-up:
1. New empty presentation.
2. Create two slides.
3. Hide Slide 1 through either the Hide-Slide button or Slide Show menu.
4. Do not hide Slide 2.
4. Make Slide 1 visible in the main window.
5. Play slide show (not custom slide show) via F5 or the Slide Show menu.
Result:
The presentation starts with Slide 1 (the hidden slide).  I believe this behavior would be unexpected to the user.  By comparison, with the same starting configuration, Microsoft Powerpoint 2010 will start the presentation with the first non-hidden slide when you press F5.  It also seems inconsistent with Test 2:  In that test, Slide 1 was also visible in the main window, yet Impress would not play the slide show with the hidden slide.

Test 4:
Variant of Test 3 with custom slide show
Set-up:	
1. Repeat steps 1-4 of Test 3
2. Go to menu Slide Show -> Custom Slide Show...
3. Click button "New... "
4. Add Slides 1 and 2 to the Selected Slides pane, and press OK.
5. Check "Use Custom Slide Show"
6. Press "Close" button
7. Start the presentation via the "Start" button, F5, or the Slide Show menu.
Result:
Only Slide 2 is displayed in the presentation.  The result is the same whether Slide 1 or Slide 2 is selected when the presentation starts.  This behavior is as expected, but it does seem inconsistent with the result of Test 3.

Overall:
There does not seem to be a bug dependency on how many slides are in the custom slide show; they just all must be hidden, and you must use a custom slide show to initiate the crash.

Impact:
There is the potential for the loss of unsaved work, which would be troublesome for many users.  However, users would not be likely to run a custom slide show with all hidden slides frequently, so the overall impact is probably minimal.  Another risk is a delay when presenting to professional colleagues or clients.   The results of Test 3 could allow attendees to view information that the presenter did not intend to share.
Comment 20 Pamela 2016-07-19 19:47:45 UTC
Pamela Quintana, 07/11/16
I was able to replicate it with version 4.1.2 installed on Windows 7 Enterprise SP1 64-bits . 

Below just a simple scenario:
1. Create a new presentation in OO IMPRESS
2. Add 2 slides, write some text on them
3. Go to Slide Show> Custom Slide Show... in the menu bar
4. Click on New
5. Add the second slide(s) from the "Existing slides" box to the "Selected 
slides" box by clicking the ">>" button and click OK
6. Check the option "Use Custom Slide Show"
7. Click Close in the 'Custom Slide Shows' window
8. Hide the slide included in the custom list(right click over the slide and select the option 'Hide Slide')
9. Click F5 to play presentation

Actual Result:
IMPRESS application crashed with the message "OpenOffice 4.1.2. has stopped working".

Expected Result:
Just not to play, option disabled since all the slides in the custom list are hidden. 

My comments:
I had verified the case where all the slides in the presentation are hidden, try playing with and/or adding some of them in the custom list and problem is not reproduced, since the option to play is disabled. In the scenario described previous steps; having not all slides hidden makes the play option enabled and hiding all the ones included in the custom is the same to have all the slides in the presentation hidden while having the option "Use Custom Slide Show" selected , so maybe the 'Slide Show' action could be disabled also in this scenario.
This scenario could be not common, but the result from my point of view is critical, it could impact the user in case the presentation was not saved, in my case the Document Recovery window was displayed when launch the application after the crash, click on Start Recovery> Next seems my untitled document recovered, but it is displayed as blank presentation.
Comment 21 oooforum (fr) 2018-07-09 09:58:53 UTC
Set type as PATCH
I don't know if it has been commited in AOO 4.x.x?