Apache OpenOffice (AOO) Bugzilla – Issue 111080
verbose/non-pro build breaks at canvas/source/vcl/canvashelper_texturefill.cxx
Last modified: 2013-01-29 21:51:34 UTC
Compiling: canvas/source/vcl/canvashelper_texturefill.cxx g++ -fmessage-length=0 -c -DENABLE_LAYOUT=0 -DENABLE_LAYOUT_EXPERIMENTAL=0 -I. -I../../unxlngx6/inc/vclcanvas -I../inc -I../../inc/pch -I../../inc - I../../unx/inc -I../../unxlngx6/inc -I. - I/mnt/build/openoffice/latest/solver/300/unxlngx6/inc/stl - I/mnt/build/openoffice/latest/solver/300/unxlngx6/inc/external - I/mnt/build/openoffice/latest/solver/300/unxlngx6/inc - I/mnt/build/openoffice/latest/solenv/unxlngx6/inc - I/mnt/build/openoffice/latest/solenv/inc -I/mnt/build/openoffice/latest/res - I/mnt/build/openoffice/latest/solver/300/unxlngx6/inc/stl - I/mnt/build/openoffice/latest/solenv/inc/Xp31 -I/opt/jdk/include - I/opt/jdk/include/linux -I/opt/jdk/include/native_threads/include - I/usr/include -I/mnt/build/openoffice/latest/solver/300/unxlngx6/inc/offuh -I. -I../../res -I. -pipe -fvisibility-inlines-hidden -g -Wall -Wextra -Wendif- labels -Wshadow -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -fpic - DLINUX -DUNX -DVCL -DGCC -DC341 -DX86_64 -D_STLP_DEBUG -DGLIBC=2 -D_PTHREADS - D_REENTRANT -DNEW_SOLAR -D_USE_NAMESPACE=1 -DSTLPORT_VERSION=400 - DHAVE_GCC_VISIBILITY_FEATURE -DX86_64 -D__DMAKE -DUNIX -DCPPU_ENV=gcc3 - DGXX_INCLUDE_PATH=/usr/include/c++/4.4.3 -DSUPD=300 -DDBG_UTIL - DOSL_DEBUG_LEVEL=1 -DOPTIMIZE -DCUI -DSOLAR_JAVA -DVERBOSE -DSHAREDLIB - D_DLL_ -fexceptions -fno-enforce-eh-specs -DEXCEPTIONS_ON -o ../../unxlngx6/slo/canvashelper_texturefill.o /mnt/build/openoffice/latest/canvas/source/vcl/canvashelper_texturefill.cxx /mnt/build/openoffice/latest/canvas/source/vcl/canvashelper_texturefill.cxx: In function 'bool vclcanvas::<unnamed>::gradientFill(OutputDevice&, OutputDevice*, const canvas::ParametricPolyPolygon::Values&, const std::vector<Color, std::allocator<Color> >&, const PolyPolygon&, const com::sun::star::rendering::ViewState&, const com::sun::star::rendering::RenderState&, const com::sun::star::rendering::Texture&, int)': /mnt/build/openoffice/latest/canvas/source/vcl/canvashelper_texturefill.cxx:709 : error: 'aTextureTransform' was not declared in this scope dmake: Error code 1, while making '../../unxlngx6/slo/canvashelper_texturefill.obj' Looking at the logs, it seems changest 267237 [(ebfadb05b72f) Fix dxcanvas gradient glitches] seems aTextureTransform in http://svn.services.openoffice.org/opengrok/xref/DEV300_m77/canvas/source/vcl/c anvashelper_texturefill.cxx#709 http://svn.services.openoffice.org/opengrok/xref/DEV300_m77/canvas/source/vcl/c anvashelper_texturefill.cxx#718 should be replaced by aTotalTransform.
ugh. looking into it. *did* build linux non-pro, funny this went in - and it's more like P1 then ...
ah nope. looking at the code now, this is debug code - so you don't seem to run a default build setup, which should not define VERBOSE. buggy still, but will fix this in a follow-up cws along with a renamed debug trace macro.
adjust summary
Created attachment 69065 [details] Initial fix
target - @all, any existing, coherent convention how to name an env var to enable "extra-verbose" debug mode? I have a hard time coming up with something equally fitting as VERBOSE.
@thb: I do not understand what you want to use an additional env var for here. What exactly do you refer to with the "VERBOSE" you mention in <#desc3> and <#desc6>, the VERBOSE env var to control verbosity of the build output?
@sb: sorry for the (obviously) opaque question - the code in question here adds extra graphical clues to the render output of the canvas, and back in the day, I picked "VERBOSE" as the env var to enable that. So "build debug=t verbose=t" yields a canvas with this additional, graphic verbosity enabled. Just wondering if someone knows of an existing convention naming that.
@thb: I see. Maybe you could tie the additional functionality to the OSL_DEBUG_LEVEL instead.
@thb: ups sorry for not mentioning the build options I was using. I built with ./configure \ --with-use-shell=bash \ --enable-qadevooo \ --enable-crashdump=yes \ --enable-cairo --with-system-cairo \ --enable-opengl \ --enable-dbus \ --enable-kde --disable-kdeab \ --enable-minimizer \ --enable-presenter-console \ --enable-pdfimport \ --enable-wiki-publisher \ --enable-report-builder \ --with-package-format="rpm" \ --with-mingwin=i686-pc-mingw32-g++ \ --with-jdk-home=/opt/jdk \ --with-lang="es" \ --enable-graphite \ --enable-kde4 --with-system-zlib \ --enable-verbose \ --disable-strip-solver --enable-dbgutil \ --enable-mysql-connector --with-system-mysql \ --enable-presenter-extra-ui --disable-binfilter So yes, --enable-verbose and --enable-dbgutil caused the build breaker. http://svn.services.openoffice.org/opengrok/xref/DEV300_m77/canvas/source/vcl/ca nvashelper_texturefill.cxx#703 already uses OSL_DEBUG_LEVEL #if defined(VERBOSE) && OSL_DEBUG_LEVEL > 0 you could just drop the defined(VERBOSE) and increase the OSL_DEBUG_LEVEL if you do not want this code to be compiled in a NON-PRO build, IIRC configuring with - -enable-dbgutil passes to the compiler -DDBG_UTIL -DOSL_DEBUG_LEVEL=1 so, for example: #if OSL_DEBUG_LEVEL > 2 would be compiled if you explicitely build with: build dbglevel=3 There are several of this in vcl for example: http://svn.services.openoffice.org/opengrok/search? q=%22OSL_DEBUG_LEVEL+%3E+2%22&defs=&refs=&path=vcl&hist=&project=/DEV300_m77
ah neat, yeah, "build dbglevel=3" looks easy enough. thx!
OOo 3.3 is in showstopper-mode. This issue doesn't look like a stopper for the current release. I change the target to OOo 3.x. Please change the target accordingly when a fix is near to be integrated into a code line or promote it as stopper issues at the mailing list releases@openoffice.org, when it is urgent enough for OOo 3.3.
Reset to default assignee.