Issue 114012 - sd: a11y crash because ctor chain calls back into object before ctor is complete
Summary: sd: a11y crash because ctor chain calls back into object before ctor is complete
Status: CONFIRMED
Alias: None
Product: Draw
Classification: Application
Component: code (show other issues)
Version: OOO330m4
Hardware: All Linux, all
: P3 Trivial (vote)
Target Milestone: ---
Assignee: AOO issues mailing list
QA Contact:
URL:
Keywords:
Depends on:
Blocks: 90439
  Show dependency tree
 
Reported: 2010-08-20 10:50 UTC by caolanm
Modified: 2017-05-20 11:27 UTC (History)
1 user (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
fix like so (974 bytes, patch)
2010-08-20 10:51 UTC, caolanm 		no flags Details | Diff
replacement patch (866 bytes, patch)
2010-08-24 15:55 UTC, caolanm 		no flags Details | Diff
rats, still loads of crashes, moving the workaround up another level (1.26 KB, patch)
2010-08-27 13:47 UTC, caolanm 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description caolanm 2010-08-20 10:50:52 UTC 
AccessibleSlideSorterView::AccessibleSlideSorterView
has...
mpImpl(new Implementation(*this,rSlideSorter,pContentWindow)),
that AccessibleSlideSorterView::Implementation ctor calls UpdateChildren which
calls that AccessibleSlideSorterView::Implementation::GetAccessibleChild which
calls mrAccessibleSlideSorter.FireAccessibleEvent where mrAccessibleSlideSorter
is the original "this" object of the AccessibleSlideSorterView which is still
being constructed

The callback from that FireAccessibleEvent is the 
AccessibleSlideSorterView::getAccessibleChildCount of the parent object where
mpImpl is still unset because we're still in a stacktrace from
AccessibleSlideSorterView::AccessibleSlideSorterView mpImpl(... which hasn't
completed yet.

Attached is a patch to split the initialization so that we call the bits that
callback into the parent object *after* mpImpl has been set
Comment 1 caolanm 2010-08-20 10:51:39 UTC 
Created attachment 71217 [details]
fix like so
Comment 2 wolframgarten 2010-08-20 11:39:24 UTC 
Reassigned. Please handle.
Comment 3 caolanm 2010-08-24 15:55:51 UTC 
Created attachment 71320 [details]
replacement patch
Comment 4 caolanm 2010-08-24 15:58:14 UTC 
a11y is a bit messed up here, the Implementation::Implementation ctor calls
Clear which calls dispose which resets mpImpl to 0, all before we leave the
AccessibleSlideSorterView:: ctor. Attached is a replacement hack.
Comment 5 caolanm 2010-08-27 13:47:03 UTC 
Created attachment 71427 [details]
rats, still loads of crashes, moving the workaround up another level
Comment 6 Rob Weir 2013-03-11 15:02:46 UTC 
I'm adding this comment to all open issues with Issue Type == PATCH.  We have 220 such issues, many of them quite old.  I apologize for that.  

We need your help in prioritizing which patches should be integrated into our next release, Apache OpenOffice 4.0.

If you have submitted a patch and think it is applicable for AOO 4.0, please respond with a comment to let us know.

On the other hand, if the patch is no longer relevant, please let us know that as well.

If you have any general questions or want to discuss this further, please send a note to our dev mailing list:  dev@openoffice.apache.org

Thanks!

-Rob
Comment 7 Marcus 2017-05-20 11:27:43 UTC 
Reset assigne to the default "issues@openoffice.apache.org".