Apache OpenOffice (AOO) Bugzilla – Issue 116266
gbuild and precompiled headers
Last modified: 2013-03-11 14:59:38 UTC
gbuild is supporting precompiled headers for Microsoft Visual tools, not for gcc. If gbuild is going to support precompiled headers for gcc in the future, the extension (.pch) should be supplied by platform makefile as .gch is the required extension for precompiled headers for gcc.
Created attachment 75453 [details] Patch set to supply precompiled header extensions from platform makefile
.
@tono: Could be done, but maybe it is better to have a separate platform file for wnt with msvc and wnt with gcc as they are very different per se. Also note that using precompiled headers on gcc is still very, very fragile and badly needs better documentation. Also note that you will need to make precompiled headers work together with dependency generation: You will want gcc to emit dependencies excluding the precompiled header and everything that was just pulled in because of the pch. Otherwise you would need to generate deps in a second additional step either with gcc or makedepend and that will likely have a lot more negative impact than the advantage of using pch with gcc.
@b_michaelsen: Do you think it better to give up using precompiled headers with gcc on wnt as well as un*x? Or are you suggesting using different class names? To give a try to unsing precompiled headers with gcc (on wnt or on un*x) and use the same class name sets as on windows MSVC platform, the suffix should be supplied from platform dependent makefile. Please take a look at i#116264 for the separate platform file for wnt platform with gcc.
@tono: "Do you think it better to give up using precompiled headers with gcc on wnt as well as un*x?" From my point of view, yes, at least for now. We might take a look at it later, for now I am more concerned to make the build system rock solid. Of course, you are free to give it a try it anyway ;). I just assumed it to be to fragile to try it in the first integration of the build system, esp. assuming that on *nix platforms the performance gain is rather small. That might be different for mingw as file i/o hits performance much harder on Windows in general.
I'm adding this comment to all open issues with Issue Type == PATCH. We have 220 such issues, many of them quite old. I apologize for that. We need your help in prioritizing which patches should be integrated into our next release, Apache OpenOffice 4.0. If you have submitted a patch and think it is applicable for AOO 4.0, please respond with a comment to let us know. On the other hand, if the patch is no longer relevant, please let us know that as well. If you have any general questions or want to discuss this further, please send a note to our dev mailing list: dev@openoffice.apache.org Thanks! -Rob