Issue 121946 - [UCB] css::ucb::XWebDAVCommandEnvironment - use enums to identify WebDAV/HTTP methods
Summary: [UCB] css::ucb::XWebDAVCommandEnvironment - use enums to identify WebDAV/HTTP...
Status: CLOSED FIXED
Alias: None
Product: App Dev
Classification: Unclassified
Component: api (show other issues)
Version: 3.4.1
Hardware: All All
: P3 Normal
Target Milestone: 4.0.0
Assignee: Ariel Constenla-Haile
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-24 02:01 UTC by Ariel Constenla-Haile
Modified: 2017-05-20 09:32 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description Ariel Constenla-Haile 2013-03-24 02:01:56 UTC 
css::ucb::XWebDAVCommandEnvironment::getUserRequestHeaders() uses a string to identify the WebDAV/HTTP method.

It would be better to use a constant instead of a string.
Comment 1 SVN Robot 2013-03-24 13:23:39 UTC 
"arielch" committed SVN revision 1460363 into trunk:
i121946 - Use enums to identify WebDAV/HTTP methods
Comment 2 Ariel Constenla-Haile 2013-03-24 13:32:10 UTC 
Fixed on trunk
Comment 3 Ariel Constenla-Haile 2013-03-26 00:23:42 UTC 
Adapting the title, I had to use enums, DELETE is a macro in winnt.h :

#define DELETE (0x00010000L)

I could have worked around this in the source file using ifdefs and undef, but it would have been a breaker if anyone ever uses the constant in the future.