Issue 122919 - [SVG] svgcirclenode uses wrong numbertype for radius
Summary: [SVG] svgcirclenode uses wrong numbertype for radius
Status: CLOSED FIXED
Alias: None
Product: Draw
Classification: Application
Component: code (show other issues)
Version: 4.0.0
Hardware: All All
: P3 Normal (vote)
Target Milestone: ---
Assignee: AOO issues mailing list
QA Contact: RottenEogat@gmail.com
URL:
Keywords:
Depends on: 122600
Blocks:
  Show dependency tree
 
Reported: 2013-07-31 21:22 UTC by Regina Henschel
Modified: 2017-05-20 10:33 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
file to reproduce the wrong radius (436 bytes, image/svg+xml)
2013-07-31 21:22 UTC, Regina Henschel 		no flags Details
Set all units to px, to make the drawing comparable with browsers (436 bytes, image/svg+xml)
2013-08-28 13:51 UTC, Regina Henschel 		no flags Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description Regina Henschel 2013-07-31 21:22:33 UTC 
Created attachment 81222 [details]
file to reproduce the wrong radius

The parameter r is neither a x-coordinate nor a width nor a y-coordinate nor a height. Therefore for percentage values the case "any other length" in SVG1.1 section 7.10 has to be used. That is the sqrt(w^2+h^2)/sqrt(2), where w and h is the size of its viewport. In case of w=6cm and h=8cm this should result in a r=7.07cm for 100%. To get this, the call of solve has to use the numbertype length and not xcoordinate.
Comment 1 Regina Henschel 2013-08-05 00:34:16 UTC 
The ellipse has the same problem. A fix is contained in the patch at bug 122600.
Comment 2 Regina Henschel 2013-08-05 07:17:06 UTC 
Comment on ellipse is wrong. Ellipse is ok, only circle is wrong, will reset that in the patch.
Comment 3 Regina Henschel 2013-08-28 13:51:17 UTC 
Created attachment 81404 [details]
Set all units to px, to make the drawing comparable with browsers

The circle radius is now the same as in common browsers. Verified on AOO 4.0.1 r1517538 and trunk r1517803
Comment 4 Regina Henschel 2013-08-28 13:52:12 UTC 
varified