Issue 152 - IssueZilla whinemails are not sent
Summary: IssueZilla whinemails are not sent
Status: CLOSED FIXED
Alias: None
Product: Infrastructure
Classification: Infrastructure
Component: Bugzilla (show other issues)
Version: current
Hardware: All All
: P2 Trivial (vote)
Target Milestone: ---
Assignee: Unknown
QA Contact: issues@www
URL:
Keywords:
Depends on:
Blocks: 1462
  Show dependency tree
 
Reported: 2000-11-15 13:21 UTC by stx123
Modified: 2003-12-27 10:23 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
Patch to make this whine only on P1 and P2 bugs (683 bytes, patch)
2003-12-06 14:52 UTC, issues@www
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this issue.
Description stx123 2000-11-15 13:21:37 UTC
The current IssueZilla parameters say, that after 7 days a whinemail should be 
sent.
whinedays: 7
The number of days that we'll let an issue sit untouched in a NEW state before 
our cronjob will whine at the owner.
These whine mails are not sent. Is this cronjob running?
Comment 1 Unknown 2000-11-21 05:53:16 UTC
Since application administration/operation, 
reassigning to jeremy@collab.net.
Comment 2 Unknown 2000-11-28 05:36:17 UTC
Jeremy, 

Status report on this?
Comment 3 Unknown 2000-11-28 16:07:16 UTC
Waiting for resources to come available to set this up.
Comment 4 Unknown 2000-11-29 05:04:46 UTC
Can this be set-up to whine only on P1 and P2 issues? Is there an ETA as to 
when this could be done?
Comment 5 issues@www 2000-11-29 19:24:39 UTC
It might be hard to set it up to whine only on certain types of issues. First, I 
think we should think about weather we want whinemail in the first place. 
After some debate mozilla.org just turned them off because they were 
annoying and not useful. Since -new bugmail already comes, it serves the 
same purpose of whinemail. This should be discussed on the mailinglist 
before anything is done.
Comment 6 Unknown 2000-12-12 17:52:24 UTC
There is some hesitancy to deploy this nag w/o discussing it further.

Goolie,

Can you spawn this discussion before we proceed?

--jeremy
Comment 7 stx123 2000-12-12 19:29:47 UTC
I (and our QA conatcts) would like to see whinemails, because I feel otherwise
issues are not handled in a reasonable timeframe. But we may discuss this on
OOo, if this takes place in a reasonable timeframe :-)
Comment 8 Unknown 2001-01-04 01:49:05 UTC
I'm reducing this to a P2 since it's not a "showstopper" bug.

Zach, could you estimate how much work would be necessary to add functionality 
to whinemail that would allow us to only get whines on P1 or P2 issues?  If you 
are not the right person to estimate this, who would be?



Comment 9 issues@www 2001-01-04 01:52:11 UTC
Shouldn't be too hard. I'll take this one and make a patch for it. Should be 
a 1 line addition.
Comment 10 issues@www 2001-01-04 01:52:28 UTC
taking
Comment 11 issues@www 2001-01-04 03:37:25 UTC
I have the patch. Attaching it now. It should work fine, I did some testing 

with it and my test bugzilla installation.
Comment 12 issues@www 2001-01-04 03:39:54 UTC
Created attachment 55 [details]
Patch to make this whine only on P1 and P2 bugs
Comment 13 issues@www 2001-01-10 02:01:53 UTC
Can we get review on this?
Comment 14 stx123 2001-02-19 15:04:26 UTC
There are 9 out of 19 unresolved p1/p2 issues unchanged since 7 days in state
NEW. I think we need whinemails now!

I'm of the opinion that all 65 of 95 issues in state new unchanged since 7 days
need a whinemail, because lower priority bugs tend to dangle even longer...
Comment 15 issues@www 2001-02-19 16:16:04 UTC
Why don't we start whining for P1 and P2 bugs first, and goolie can 

discuss this on the general list to get comment. For me, very few things 

annoy me more than getting an email a day about bugs that I don't care 

about...
Comment 16 stx123 2001-02-19 17:29:09 UTC
Agreed, that we should start with whinemails for P1/P2 now without discussion.
For others Goolie may ask the community.
Comment 17 Unknown 2001-03-02 00:25:04 UTC
Looking into getting an engineering review
Comment 18 Unknown 2001-03-02 00:25:46 UTC
.
Comment 19 Unknown 2001-03-15 01:13:55 UTC
Update:

********************************************************
Date: Wed, 14 Mar 2001 16:30:14 -0800
From: Kevin Maples <kmaples@collab.net>
To: Adam Gould <goolie@collab.net>
Subject: Re: IZ patch:  whine on P1 and P2 issues only

Hey Goolie,

Here's my assessment of http://www.openoffice.org/issues/show_bug.cgi?id=152 :

The patch is fine; it will do what's advertised.  The problems at
this point are several, however

- whineatnews.pl is a cron job, one that we haven't enabled on any of
our instantiations
- we are in the process of evaluating the upgrade between the
installed version of sourcecast on openoffice, and the current
version, and there are major differences between these codebases
(especially in issuezilla).  This expected to be a signifigant effort
- it would be unwise to enable any crons in advance of that upgrade
- we need to establish how this cron would fit into the handling of
crons in the current version of sourcecast
- we need to qa the interaction of whineatnews.pl our current mail handling

If you can get Chris to sign off on this, though, it seems like a
reasonable change to make to the HEAD, and we can certainly be
prepared to enable it post-upgrade.

Thanks,

- Kevin


--
Kevin P. Maples     -=-  kmaples@lfino.com | kmaples@collab.net
Software Engineer   =-=
CollabNet           -=-  http://www.collab.net/
Comment 20 Unknown 2001-04-04 02:06:05 UTC
Per our last OOo meeting, reassigning to bphipps for coordination
Comment 21 Unknown 2001-04-10 02:12:48 UTC
Accepting issue.
Comment 22 Unknown 2001-05-21 22:40:00 UTC
Working on issue.  Bill Phipps will discuss options with Stefan on
tomorrows conf call.

Currently the script will be setup to run every Friday at 20:00 hours
(8PM PST, 4AM Hamburg time)

Please address any concerns to Bill Phipps.
Comment 23 Unknown 2001-05-24 17:57:45 UTC
Stefan,

Could you please update or close this issue when
you are satisfied with the time and day that whinemail runs.

Thanks
Shane
Comment 24 stx123 2001-05-28 11:16:08 UTC
Time is ok.
I'll set status to verified once I get the first reminder for my issues 97 and
452.
Comment 25 Unknown 2001-05-29 07:09:58 UTC
Stefan, 

AFAIK, 
per the following script comments: 

# This is a script suitable for running once a day from a cron job.  It 
# looks at all the bugs, and sends whiny mail to anyone who has a bug 
# assigned to them that has status NEW that has not been touched for
# more than 7 days.

you should have already received whiny mail for OpenOffice.org Issue#: 97 
(which has Status: NEW and has not been touched since Opened: 2000-11-06 
01:46). 

Please confirm that you have not yet received the corresponding whiny mail 
and I will plan to follow-up with our Operations group 
toward confirming that the CRON job was successfully set-up and executed on 
schedule initially last Friday. 
Comment 26 stx123 2001-05-29 12:06:39 UTC
I have NOT received a whine mail.
Is the behaviour of the script defined if it is run once a week instead of once 
a day as descibed in the header?
I prefer the way it is setup now, but does it work?
Comment 27 issues@www 2001-05-29 15:46:59 UTC
The script should run once per day, not week. It generates a list of issues 

to whine upon (more than [whinedays param] days old, NEW, and P1+

P2?) then sends out the emails. Also, is the whinedays param set to 0. 

This is the number of days that the script should wait before sending mail 

on an issue. Also, please please please setup a .htaccess file not to 

allow users to run the script from their web browsers, one can start a DoS 

attack very easily like that. 
Comment 28 stx123 2001-05-29 15:56:01 UTC
Bill and Shane had machine load problems in mind to let it run once a week.
Does this work?
How often will the reminder be sent after the initial period of "whinedays" (7)?
With every run or after another period of whinedays?
Comment 29 Unknown 2001-05-29 18:17:41 UTC
Understood regarding the original intended whine mail use model, 
but based upon project owner requests, potential developer response 
as well as system load and administration considerations, 
the tradeoff recommendation was to schedule the corresponding cron job weekly 
(rather than daily), initially for all (rather than only for P1 + P2) issues. 

The thought was that issue whine mails would be sent to facilitate weekly 
status reviews by project owners and developers. 

Depending upon developer, as well as project owner, feedback,
the cron job could be rescheduled to daily 
and/or 
the patch to limit whine mail to only P1 + P2 issues could be applied to this 
original script.

This should have worked by simply changing the associated cron job schedule, 
but I will plan to follow-up regarding the whinedays param. 

BTW ... 
AFAIK, 
access to the whine mail script and IssueZilla database is restricted, 
so users cannot run the script.
Comment 30 Unknown 2001-05-29 20:01:25 UTC
By looking at the script source I don't see why it can't
just be ran once a week.

As this section of the code seems to be able to handle
being run weekly.

SendSQL("select issue_id,login_name from issues,profiles where " .
        "issue_status = 'NEW' and to_days(now()) - to_days(delta_ts) > " .
        Param('whinedays') . " and userid=assigned_to order by issue_id");


Granted with this approach users will not be notified each day after
the 7th, but they will be notified each week after the first 7 days
of inactivity (plus some number of days up to the first week time slice).

I just checked the machine....the cronjob is set, and there were
no error messages reported.
Shane
Comment 31 Unknown 2001-05-31 21:09:12 UTC
For clarification (at least for me) 
from The Bugzilla Guide ... 

Set "whinedays" to the amount of days you want to let bugs go in the "New" 
or "Reopened" state before notifying people they have untouched new bugs. If 
you do not plan to use this feature, simply do not set up the whining cron job 
described in the README, or set this value to "0". 
Comment 32 Unknown 2001-05-31 22:16:12 UTC
ok, we found the problem.  When running the whine mail script
the present working directory had to be the same
directory that the script was in.

The script was manually ran today, and the cronjob will function
correctly in the future.

Thanks
Shane

BTW here are the ppl who got email from the initial run:

[root@openoffice issuezilla]# ./whineatnews.pl
Armin.Weiss@germany.sun.com 498
Malte.Timmermann@germany.sun.com 591 862
bettina.haberer@germany.sun.com 721 745 746 747 762 836 856 920 926
dan.roberts@sun.com 592
eric.savary@germany.sun.com 398 552 906
eric@noonetime.com 569
falko.tesch@germany.sun.com 918 932
frank.loehmann@germany.sun.com 450
gallwey@sun.com 911
goolie@collab.net 738 779 940
hans-peter.burow@germany.sun.com 594
hennes.rohling@germany.sun.com 159 424 441 527
ingo.schmidt@germany.sun.com 547
jakub.nadolny@ite.pl 622
jonathan.mills@sun.com 576
kai.ahrens@germany.sun.com 821
kay.ramme@germany.sun.com 20 840 898
lars.langhans@germany.sun.com 436
lutz.hoeger@Germany.sun.com 268
majkel.kretschmar@epost.de 651
martin.hollmichel@germany.sun.com 835 883
michael.hoennig@germany.sun.com 670 868
michael.ruess@germany.sun.com 857 922
news@test.openoffice.org 252 453 891 896
oisin.boydell@ireland.sun.com 338
oliver.krapp@germany.sun.com 132 542 544 557 597 636 666 846
robert.kinsella@ireland.sun.com 830
ronchi@csr.unibo.it 899
sander.vesik@ireland.sun.com 783 787 791 794 803 805 810 816 890
stefan.baltzer@germany.sun.com 948
stefan.taxhet@germany.sun.com 97 452
thomas.hosemann@germany.sun.com 472 894
tino.rachui@germany.sun.com 904
uwe.luebbers@germany.sun.com 273 356 829 893 938
zeroJ@null.net 788


We also tested the cronjob to make sure it ran correctly......so
these users got more than 1 email reminder about each issue.
This was necessary for testing.

Best Regards, 
Shane
Comment 33 stx123 2001-06-05 10:43:48 UTC
I got my friendly reminder....