Issue 36150 - Correct setting the Undo-Stack when TextEdit
Summary: Correct setting the Undo-Stack when TextEdit
Status: ACCEPTED
Alias: None
Product: Draw
Classification: Application
Component: editing (show other issues)
Version: 3.4.1
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: AOO issues mailing list
QA Contact:
URL:
Keywords: oooqa
Depends on:
Blocks:
 
Reported: 2004-10-26 16:12 UTC by Armin Le Grand
Modified: 2013-02-21 22:57 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description Armin Le Grand 2004-10-26 16:12:54 UTC 
AW->AF: This is a follow-up to #i35363#. Necessary steps are:
(1) Correctly set Undo-Stack of the EditEngine when TextEdit Starts/Ends (in
View::BegTextEdit and View::EndTextEdit)
(2) Force EndTextEdit() when the shell containing the OutlinerView in edit mode
loses the focus (to be sure that the correct UndoManager is on the stack).
Comment 1 groucho266 2004-10-27 09:09:53 UTC 
Accepted.
Comment 2 groucho266 2004-11-04 16:43:17 UTC 
Step 1 is not necessary, the existing code is correct: the undo manager is set
at the top most shell on the stack.  If I understand this correctly then this
has not to be (but usually is) the text object bar to make undo work.
Comment 3 groucho266 2005-02-11 17:13:48 UTC 
I just made an experiment with calling EndTextEdit() on all views on the stack
from ViewShellManager::MoveToTop().  This ended the text editing of a simple
shape in the edit view when I clicked in the slide sorter bar.  I have not yet
checked that the implication on the UndoManager.  But then again, with the fix
for issue 35363 in place, I have not seen Undo related problems originating from
the text editing lately.
Comment 4 ooo 2005-02-25 20:21:35 UTC 
set to OOo Later
Comment 5 ace_dent 2008-05-13 23:38:38 UTC 
This is currently logged against the dummy '*TESTproduct' component? If this is
not a real Issue or has been fixed, please close.

Regards
Andrew

Cleaning-up and Closing old Issues as part of:
~ The Grand Bug Squash, pre v3 ~