Issue 56716 - `-fexceptions' is needed on a lot of new files
Summary: `-fexceptions' is needed on a lot of new files
Status: CLOSED FIXED
Alias: None
Product: porting
Classification: Code
Component: code (show other issues)
Version: 680m135
Hardware: All All
: P3 Trivial (vote)
Target Milestone: OOo 2.0.1
Assignee: panbk
QA Contact: issues@porting
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-10-26 15:44 UTC by panbk
Modified: 2006-01-17 10:57 UTC (History)
4 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Patch 19 makefile.mk's to ensure `-fexceptions', where needed (10.78 KB, patch)
2005-10-26 15:46 UTC, panbk 		no flags Details | Diff
A bigger, yet still incomplete version of the patch. 32 makefiles patched... (17.72 KB, patch)
2005-10-28 07:38 UTC, panbk 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description panbk 2005-10-26 15:44:28 UTC 
cppuhelper's interfacecontainer.h can now "throw exceptions" (since, at least   
m134) and so all files    
including it (directly and otherwise) need to be compiled with `-fexceptions'.    
    
Various makefile.mk files must now expand their lists of EXCEPTIONSFILES -- or,    
perhaps, the throwing can be removed from interfacecontainer.h...    
    
I have a patch, but it is, probably, incomplete :-( 
 
(I'm using gcc-3.4.4 on FreeBSD-6/amd64)
Comment 1 panbk 2005-10-26 15:46:04 UTC 
Created attachment 30865 [details]
Patch 19 makefile.mk's to ensure `-fexceptions', where needed
Comment 2 panbk 2005-10-28 07:14:02 UTC 
Obo, dbo! The change, that added "try/catch/throw" to   
cppuhelper/inc/cppuhelper/interfacecontainer.h  
is, apparently, by you:  
  
revision 1.16  
date: 2005/10/11 08:20:32;  author: obo;  state: Exp;  lines: +35 -1  
INTEGRATION: CWS presfixes08 (1.14.28); FILE MERGED  
2005/09/01 09:09:46 dbo 1.14.28.1: #i51786# added forEach()  
  
Can you please, take a look at all of the implications (vast number of files  
now require -fexceptions to compile) or, perhaps, revert the change or revise  
the forEach to avoid requiring exceptions?  
  
My patch currently attached to this issue is very incomplete, but it already  
gives an idea of the scope of the required changes :-( 
 
Thanks!
Comment 3 panbk 2005-10-28 07:38:00 UTC 
Created attachment 30941 [details]
A bigger, yet still incomplete version of the patch. 32 makefiles patched...
Comment 4 Daniel Boelzle [:dbo] 2005-10-28 10:20:47 UTC 
I have 

#if defined(EXCEPTIONS_OFF)
            func( xListener );
#else
            try {
                func( xListener );
...
#endif

in cppuhelper/interfacecontainer.h (rev 1.17) which ought to solve the problem;
thus there is no need to modify makefiles.

@HR: please apply to next milestone.
@panbk: Please verify whether interfacecontainer.h rev 1.17 works for you
(without patching any makefiles)
Comment 5 Daniel Boelzle [:dbo] 2005-10-28 10:22:41 UTC 
fixed.
Comment 6 Daniel Boelzle [:dbo] 2005-10-28 13:25:57 UTC 
please verify.

re-open issue and reassign to panbk
Comment 7 Daniel Boelzle [:dbo] 2005-10-28 13:26:01 UTC 
reassign to panbk
Comment 8 Daniel Boelzle [:dbo] 2005-10-28 13:26:07 UTC 
reset resolution to FIXED
Comment 9 panbk 2005-10-28 17:53:15 UTC 
Yes, seems to work. The fix looks a little "hackish" though :-)
Thanks for the quick reaction!
Comment 10 Daniel Boelzle [:dbo] 2005-10-31 08:19:16 UTC 
@panbk: please mark this issue verified...
The "solution" is not hacky; IMO it is hacky/fragile not compiling all of our
code with exception support, but allowing exceptions to be used.
Comment 11 panbk 2005-10-31 17:11:50 UTC 
verified
Comment 12 jens-heiner.rechtien 2006-01-17 10:57:04 UTC 
has long been fixed, closeing issue.