Issue 65457 - WordML import should accept content of elements of not word namespaces
Summary: WordML import should accept content of elements of not word namespaces
Status: CLOSED FIXED
Alias: None
Product: xml
Classification: Code
Component: external filters (show other issues)
Version: OOo 2.0.2
Hardware: All All
: P3 Trivial (vote)
Target Milestone: OOo 2.1
Assignee: svante.schubert
QA Contact: issues@xml
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-05-16 15:34 UTC by stefan_ziel
Modified: 2007-05-25 13:39 UTC (History)
2 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
Word document with embedded foreign elements (14.60 KB, text/xml)
2006-05-16 15:36 UTC, stefan_ziel
no flags Details
patch unfortunately includes other fixes (16.42 KB, text/plain)
2006-06-14 19:03 UTC, stefan_ziel
no flags Details
here komplete stylesheets for all my issues (23.15 KB, application/x-compressed)
2006-06-14 19:09 UTC, stefan_ziel
no flags Details

Note You need to log in before you can comment on or make changes to this issue.
Description stefan_ziel 2006-05-16 15:34:41 UTC
As word permits to mix up the WordML with elements from other namespaces these
should be ignored by the import style sheets. this could be done by substitution
of all <xsl:aplytemplates select=" ... with templates matching the not desired
elements as <xsl:template match="w:*"/> and maybe one or the other new "mode"
Comment 1 stefan_ziel 2006-05-16 15:36:20 UTC
Created attachment 36521 [details]
Word document with embedded foreign elements
Comment 2 jogi 2006-05-26 09:04:23 UTC
-> SUS
Comment 3 svante.schubert 2006-06-13 18:16:17 UTC
SUS->Stefan:
Hi Stefan,

is there a chance to get a patch for this as well.
I inherited this filter, but have unfortunately other higher prioritized tasks,
which keep me from fixing this.
Any help is welcome.

Many thanks in advance,
Svante
Comment 4 stefan_ziel 2006-06-13 21:52:18 UTC
Hi Svante,
unfortunately this is not just a little patch ... _all_ <xsl:apply-templates
select=" ... " /> elements will have to be replaced by a dispatch template. but
I will do a try :-)

Greetings 
Stefan
Comment 5 svante.schubert 2006-06-14 13:23:34 UTC
Hi Stefan,

That are great news for me!

Therefore I gave you back the issue and postponed the CWS till 7th June.

As you will have to do a lot of search & replace, you might as well simply sent
me (or better attach) a ZIP with your latest stylesheet collection and I will do
a codereview by looking at the diffs.

By this neither of us have to worry about the patches.

Many thanks for your help. 
I am impressed by your commitment.

Regards,
Svante
Comment 6 stefan_ziel 2006-06-14 19:03:27 UTC
Created attachment 37158 [details]
patch unfortunately includes other fixes
Comment 7 stefan_ziel 2006-06-14 19:09:24 UTC
Created attachment 37159 [details]
here komplete stylesheets for all my issues
Comment 8 stefan_ziel 2006-06-14 19:45:26 UTC
hi svante 

for me and my application it works fine now. but unfortunately i dont have any
test suite to verify all possible side effekts.

regards 
stefan
Comment 9 svante.schubert 2006-06-27 10:36:10 UTC
Hi Stefan,

we have a automatic testing tool to compare the documents after loading into the
Office.

Basically the tool load on document after the other into the Office, prints them
in a postscript file and transforms the file into a graphic. 

If you do this process twice, once for the earlier used import filter and
afterwards for the one for the export filter, it is possible to compare the
graphics for differences.

As you did fixes, there will be some changes for sure.

But as this tool is not well documented in the public yet and Sun might have
more test documents (which we are not able to make public as they are partly
customer documents), I will start to run this tool on your filter.

PS: As you are the only developer on the CWS and to avoid confusions with the
patches, would you be so kind to bundle the final version of your import &
export filter in a ZIP to this issue? In the end, it would ease things on my side.

Kind regards,
Svante
Comment 10 stefan_ziel 2006-07-11 21:23:20 UTC
hi svante,

my atachment (wordml.zip) from june 14th contains all alterations made up to the
moment. there is still very much to be done especially header and footer
treatment but ATM ... no way. who knows ... maybe in september I´ll be back on this.

best regards 
stefan
Comment 11 svante.schubert 2006-07-12 13:29:09 UTC
sus->stephan:

Excellent, thank-you.
Therefore I going to trigger the QA for automated GUI testing.

Regards,
Svante
Comment 12 svante.schubert 2006-07-17 12:47:54 UTC
This patch can be reproduced upon the attached document.
Therefore it is accepted.

NOTE:
This issue allows only to import the content of those documents, it does not
preserve those elements.
Comment 13 svante.schubert 2006-07-31 20:17:26 UTC
patched checked in and tested..
Comment 14 jack.warchold 2006-08-17 14:22:09 UTC
seen good in cws wordml02

set to verified
Comment 15 Martin Hollmichel 2006-09-05 07:34:48 UTC
set target to 2.1
Comment 16 svante.schubert 2007-05-25 13:39:32 UTC
Closing long ago verified issues