Issue 68216 - DrawViewShell::GetMenuState shouldn't rely on non-documented toolbar controller implementation detail
Summary: DrawViewShell::GetMenuState shouldn't rely on non-documented toolbar controll...
Status: CONFIRMED
Alias: None
Product: Draw
Classification: Application
Component: code (show other issues)
Version: OOo 2.0
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: AOO issues mailing list
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-08-07 10:49 UTC by carsten.driesner
Modified: 2017-05-20 10:47 UTC (History)
4 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description carsten.driesner 2006-08-07 10:49:30 UTC 
The current implementation of DrawViewShell::GetMenuState doesn't really provide
status information for all slots for all scenarios. The implementation relies on
the fact that the toolbar controller interpret a SfxVoidItem on a checked button
as a "please uncheck" status. Currently the toolbar uses this interpretation. As
this behavior is undocumented and questionable DrawViewShell::GetMenuState()
should send correct state information for all scenarios. At least the following
slots need a defined status (it's possible that this list is not complete!):

- SID_OBJECT_SELECT
- SID_ATTR_CHAR
- SID_DRAW_LINE
- SID_DRAW_RECT
- SID_DRAW_ELLIPSE

- SID_DRAWTBX_ARROWS
- SID_LINE_ARROW_END

- SID_DRAWTBX_3D_OBJECTS
- SID_3D_CUBE
- SID_3D_SPHERE
- SID_3D_CYLINDER
- SID_3D_CONE
- SID_3D_CYRAMID
- SID_3D_TORUS
- SID_3D_SHELL
- SID_3D_HALFSPHERE
Comment 1 carsten.driesner 2006-08-07 10:51:31 UTC 
cd: Set correct version.
Comment 2 Martin Hollmichel 2007-11-09 17:01:23 UTC 
set target from 2.x to 3.x according
http://wiki.services.openoffice.org/wiki/Target_3x
Comment 3 Marcus 2017-05-20 10:47:30 UTC 
Reset assigne to the default "issues@openoffice.apache.org".