Apache OpenOffice (AOO) Bugzilla – Issue 69029
Issues in svx/source/dialogs/charmap.cxx
Last modified: 2017-05-20 10:48:01 UTC
While fixing issue 67487 on CWS sb59, I discovered the following potential issues in svx/source/dialog/charmap.cxx:1.36: 1 Inconsistent mix of USHORT (GetSelectedIndex()), sal_Int32 (nSelectedIndex), int (FirstInView(), LastInView()). This has minimally been addressed on CWS sb59 to make the code warning-free on wntmsci10. 2 The elements of m_aItems seem to be leaked. 3 The static data of getSelectedChar() could be a bad idea when there are multiple instances of SvxShowCharSet simultaneously. 4 Should GetSelectedCharacter() return sal_Unicode (single UTF-16 code unit) or some >=21bit number (sal_[u]Int32) to represent Unicode scalar values? 5 Since the key is part of the value, ItemsMap could be an ItemsSet.
pb: target changed.
set target from 2.x to 3.x according http://wiki.services.openoffice.org/wiki/Target_3x
grabbing issue
Reset assigne to the default "issues@openoffice.apache.org".