Issue 69029 - Issues in svx/source/dialogs/charmap.cxx
Summary: Issues in svx/source/dialogs/charmap.cxx
Status: CONFIRMED
Alias: None
Product: Draw
Classification: Application
Component: code (show other issues)
Version: 680m182
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: AOO issues mailing list
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-08-28 15:54 UTC by Stephan Bergmann
Modified: 2017-05-20 10:48 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description Stephan Bergmann 2006-08-28 15:54:44 UTC
While fixing issue 67487 on CWS sb59, I discovered the following potential
issues in svx/source/dialog/charmap.cxx:1.36:

1  Inconsistent mix of USHORT (GetSelectedIndex()), sal_Int32 (nSelectedIndex),
int (FirstInView(), LastInView()).  This has minimally been addressed on CWS
sb59 to make the code warning-free on wntmsci10.

2  The elements of m_aItems seem to be leaked.

3  The static data of getSelectedChar() could be a bad idea when there are
multiple instances of SvxShowCharSet simultaneously.

4  Should GetSelectedCharacter() return sal_Unicode (single UTF-16 code unit) or
some >=21bit number (sal_[u]Int32) to represent Unicode scalar values?

5  Since the key is part of the value, ItemsMap could be an ItemsSet.
Comment 1 pb 2006-09-18 13:32:16 UTC
pb: target changed.
Comment 2 Martin Hollmichel 2007-11-09 17:01:44 UTC
set target from 2.x to 3.x according
http://wiki.services.openoffice.org/wiki/Target_3x
Comment 3 Mathias_Bauer 2009-05-07 13:09:09 UTC
grabbing issue
Comment 4 Marcus 2017-05-20 10:48:01 UTC
Reset assigne to the default "issues@openoffice.apache.org".