Issue 82985 - WaE on 64bit Linux: unotools
Summary: WaE on 64bit Linux: unotools
Status: CLOSED FIXED
Alias: None
Product: utilities
Classification: Unclassified
Component: code (show other issues)
Version: 680m234
Hardware: PC (x86_64) Linux, all
: P3 Trivial (vote)
Target Milestone: OOo 2.4
Assignee: ab
QA Contact: Unknown
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-10-25 20:16 UTC by pavel
Modified: 2009-07-20 15:22 UTC (History)
1 user (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description pavel 2007-10-25 20:16:29 UTC 
Hi,

on 64bit Linux:

/home/oo/BuildDir/ooo_SRC680_m234_src/unotools/source/ucbhelper/ucblockbytes.cxx: In member 
function 'virtual ErrCode utl::UcbLockBytes::ReadAt(ULONG, void*, ULONG, ULONG*) const':
/home/oo/BuildDir/ooo_SRC680_m234_src/unotools/source/ucbhelper/ucblockbytes.cxx:1542: 
warning: comparison between signed and unsigned integer expressions

The fix is simple:

diff -ur ooo_SRC680_m233_src.orig/unotools/source/ucbhelper/ucblockbytes.cxx 
ooo_SRC680_m233_src/unotools/source/ucbhelper/ucblockbytes.cxx
--- ooo_SRC680_m233_src.orig/unotools/source/ucbhelper/ucblockbytes.cxx
	2007-10-13 11:42:33.000000000 +0200
+++ ooo_SRC680_m233_src/unotools/source/ucbhelper/ucblockbytes.cxx
	2007-10-13 11:44:01.000000000 +0200
@@ -1538,7 +1538,7 @@
 	{
 		if ( !m_bTerminated && !IsSynchronMode() )
 		{
-            sal_Int64 nLen = xSeekable->getLength();
+            sal_uInt64 nLen = xSeekable->getLength();
 			if ( nPos + nCount > nLen )
 				return ERRCODE_IO_PENDING;
 		}
Comment 1 kai.sommerfeld 2007-10-26 08:45:54 UTC 
Tobias, this one is for you. Please take over. Target is 2.4
Comment 2 tkr 2007-10-26 08:54:48 UTC 
okay
Comment 3 tkr 2007-12-07 11:25:22 UTC 
patch applied in tkr08
Comment 4 tkr 2007-12-13 09:01:29 UTC 
TKR -> AB: Please verify
Comment 5 ab 2007-12-17 13:00:49 UTC 
Verified in source code
Comment 6 thorsten.ziehm 2009-07-20 15:22:03 UTC 
This issue is closed automatically and wasn't rechecked in a current version of
OOo. The fixed issue should be integrated in OOo since more than half a year. If
you think this issue isn't fixed in a current version (OOo 3.1), please reopen
it and change the field 'Target Milestone' accordingly.

If you want to download a current version of OOo =>
http://download.openoffice.org/index.html
If you want to know more about the handling of fixed/verified issues =>
http://wiki.services.openoffice.org/wiki/Handle_fixed_verified_issues