Issue 88252 - Connector undo: Sometimes unnecessary model change is created
Summary: Connector undo: Sometimes unnecessary model change is created
Status: ACCEPTED
Alias: None
Product: Draw
Classification: Application
Component: code (show other issues)
Version: DEV300m5
Hardware: PC Linux, all
: P4 Trivial (vote)
Target Milestone: ---
Assignee: AOO issues mailing list
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-04-14 11:51 UTC by richlv
Modified: 2017-05-20 10:48 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
testcase (9.01 KB, application/vnd.oasis.opendocument.graphics)
2008-04-14 11:52 UTC, richlv 		no flags Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description richlv 2008-04-14 11:51:45 UTC 
there are three problems here that seem to be similar enough to file them as a 
single issue.
if they are different, i'll be glad to file separate reports.

see attached testcase.

1. right click vertical connector, choose 'connector' click "ok".
notice how undo history is empty, but "save" icon in toolbar is enabled.

2. right click vertical connector, choose 'connector' click "ok".
change to line connector, then back to standard connector, click "ok".
undo once, notice how undo menu now contains unavailable undo entry "apply 
attributes to object connectors".

3. right click vertical connector, choose 'connector' click "ok".
set all three line skew fields to 0, click "ok".
undo - notice how connector is undone incorrectly
Comment 1 richlv 2008-04-14 11:52:16 UTC 
Created attachment 52809 [details]
testcase
Comment 2 wolframgarten 2008-04-14 13:05:16 UTC 
Reproducible. Reassigned.
Comment 3 Armin Le Grand 2008-04-15 02:52:06 UTC 
AW->SJ: Are Your changes for connectors part of DEV300 m5? If Yes, take a look
please.
Comment 4 sven.jacobi 2008-04-15 10:11:57 UTC 
sj->aw: Until now I did not change anything to the connectors. Can you please
take a look, I even have problems when trying to reproduce this issue on m5
where it should happen.

But it might be that this bug is also related to i87804 which is fixed in m6.

(The changes I made with the user defined path will soonest be included in m8)
Comment 5 Armin Le Grand 2008-05-13 13:41:56 UTC 
AW: I took a closer look. After constructing the needed test cases and files
(else no way to see model change) i see two errors remaining in DEV300 m11:

(a) Point (1) indeed creates an unnecessary model change
(b) UNDO of 2nd step in point (2) leaves the connector without refresh, but
model data is correct

I could not create an 'unavailable undo entry', nor did point (2) or (3) create
the unnecessary UNDO as (1) did. No error destroys model data. I am pretty sure
that tis errors are known and need to look for them...
Comment 6 Armin Le Grand 2008-05-13 13:48:49 UTC 
AW: 
(b) is double to #i24301#
(a) is not documented.

So i change this task to (a), including change of title.
Comment 7 Armin Le Grand 2008-07-02 15:37:27 UTC 
Added note
Comment 8 Marcus 2017-05-20 10:48:13 UTC 
Reset assigne to the default "issues@openoffice.apache.org".