Issue 89735 - Errors in the original strings (sw)
Summary: Errors in the original strings (sw)
Status: CLOSED FIXED
Alias: None
Product: Writer
Classification: Application
Component: code (show other issues)
Version: OOo 3.0 Beta
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: Marcus
QA Contact: issues@sw
URL:
Keywords: oooqa
Depends on: 89820
Blocks:
  Show dependency tree
 
Reported: 2008-05-21 15:21 UTC by clytie
Modified: 2013-08-07 14:44 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description clytie 2008-05-21 15:21:22 UTC
While translating the interface, I found these errors. I thought you would want to fix them, as they 
detract from the overall quality of the program.

I am not sure against which module to report each string: I notice clicking on "officecfg" brings me to 
"utilities", so I may be reporting in separate places strings belonging together. However, I have tried 
reporting them altogether, and that isn't OK either. So this is my effort. I hope it is useful.

1. Typo

sw	source\ui\dbui\createaddresslistdialog.src	0	string	DLG_MM_CREATEADDRESSLIST	
ST_FILTERNAME			50	en-US	%PRODUCTNAME Adress List (.csv)				2002-
02-02 02:02:02

- Adress
+ Address


2. Typo

sw	source\ui\dbui\mailmergechildwindow.src	0	fixedtext	DLG_MM_SENDWARNING	FI_WARNING			
170	en-US	The following error occured:				2002-02-02 02:02:02

- occured
+ occurred


3. Split strings

sw	source\ui\dialog\dialog.src	0	string	STR_PATH_NOT_FOUND1				0	en-US	
The directory '				2002-02-02 02:02:02
sw	source\ui\dialog\dialog.src	0	string	STR_PATH_NOT_FOUND2				0	en-US	
' does not exist.				2002-02-02 02:02:02

Split strings are bad i18n practice, because the grammar of different languages is different. That 
means we can't necessarily split the translation in the same way. Please use a placeholder, e.g.

"The directory '%1' does not exist"

to avoid this problem.

sw	source\ui\dochdl\dochdl.src	0	string	STR_NOGLOS1				0	en-US	
AutoText for Shortcut '				2002-02-02 02:02:02
w	source\ui\dochdl\dochdl.src	0	string	STR_NOGLOS2				0	en-US	' not 
found.				2002-02-02 02:02:02

sw	source\ui\uiview\view.src	0	string	STR_NOGLOS1				0	en-US	
AutoText for Shortcut '				2002-02-02 02:02:02
sw	source\ui\uiview\view.src	0	string	STR_NOGLOS2				0	en-US	' not 
found.				2002-02-02 02:02:02


4. Multiple errors due to non-spaced placeholders

sw	source\ui\utlui\utlui.src	0	string	RID_SHELLRES_AUTOFMTSTRS	
STR_AUTOFMTREDL_TYPO+1			0	en-US	Replace "standard" quotes with %1custom%2 
quotes				2002-02-02 02:02:02

Non-spaced placeholders means the whole word is interpreted as a variable by the translation error-
checker. Please find another way to do this: Every translator ends up having to check through this false 
positive every time we update the translation. 


5. Lack of spaces (three instances)

sw	source\ui\table\tabledlg.src	0	fixedtext	TP_TABLE_TEXTFLOW	FT_REPEAT_HEADER			
95	en-US	The first%POSITION_OF_CONTROLrows				2002-02-02 02:02:02

- first%POSITION_OF_CONTROLrows	
+ first %POSITION_OF_CONTROL rows	

sw	source\ui\table\instable.src	0	fixedtext	DLG_INSERT_TABLE	FT_REPEAT_HEADER			95	
en-US	The first%POSITION_OF_CONTROLrows				2002-02-02 02:02:02

sw	source\ui\table\convert.src	0	fixedtext	DLG_CONV_TEXT_TABLE	FT_REPEAT_HEADER			
66	en-US	The first%POSITION_OF_CONTROLrows				2002-02-02 02:02:02

Please add spaces. This string causes multiple errors (variables, printf, spacing etc.) when checking the 
translation, since the entire unspaced section is interpreted as a variable.


6. 10. Use of square brackets with non-variables

Since you use square brackets to indicate placeholders elsewhere, please don't use them to enclose 
translatable text, since the string is then reported as an error. You could easily use round brackets 
instead, and avoid these time-wasting errors for us.

sw	source\ui\chrdlg\chrdlg.src	0	string	SW_STR_NONE				0	en-US	[None]				
2002-02-02 02:02:02

sw	source\ui\index\cnttab.src	0	string	ST_NO_BRACKET				260	en-US	
[none]				2002-02-02 02:02:02


Clytie
Vietnamese Free-Software Translation Team
Comment 1 aziem 2008-05-26 22:42:39 UTC
"Address" solved in 89820
Comment 2 andreas.martens 2008-06-30 09:30:16 UTC
Reassigned, set target OOo3.x
Comment 3 Marcus 2008-09-26 10:44:21 UTC
set target to 3.1
reassigned to mla
Comment 4 Marcus 2008-09-26 10:57:45 UTC
as suggested I've fixed the following things in CWS mla01 in the files:

> 2. Typo
> 
> en-US		The following error occured:

fixed in file sw/source/ui/dbui/mailmergechildwindow.src

> 3. Split strings
> 
> en-US		The directory '
> en-US		' does not exist.

> en-US		AutoText for Shortcut '
> en-US		' not found.

fixed in files sw/source/ui/dialog/dialog.src
               sw/inc/dialog.hrc

               sw/source/ui/dochdl/dochdl.src
               sw/source/ui/dochdl/gloshdl.cxx

               sw/source/ui/uiview/view.src
               sw/source/ui/uiview/view.hrc

> 4. Multiple errors due to non-spaced placeholders
> 
> en-US		Replace "standard" quotes with %1custom%2 quotes

fixed in file sw/source/ui/utlui/utlui.src

> 5. Lack of spaces (three instances)
> 
> en-US	The first%POSITION_OF_CONTROLrows

fixed in files sw/source/ui/table/tabledlg.src
               sw/source/ui/table/instable.src
               sw/source/ui/table/convert.src 

> 6. 10. Use of square brackets with non-variables
> 
> Since you use square brackets to indicate placeholders elsewhere, please don't
> use them to enclose translatable text, since the string is then reported as an
> error. You could easily use round brackets instead, and avoid these
> time-wasting errors for us.

As this is not that easy to decide and applies to more locations in the code,
and in order to allow to set the other things to FIXED, I've created a new issue
94357 to split this from the issues above.
Comment 5 Marcus 2009-01-23 13:31:07 UTC
set target to 3.2
Comment 6 Oliver Specht 2009-02-04 10:51:22 UTC
Places to test: 
2. Mailmerge wizard, warning if mail error occurred
3. - ? seems to be unused
- expansion of nonexistent AutoText shortcut
4- tools/auto correct/options
5 - insert/table, table/properties and table/convert/text to table
6. - format/paragraph/drop caps/character style
-insert/indexes and tables/bibliography - brackets list box
Comment 7 stefan.baltzer 2009-02-16 10:47:55 UTC
Verified in CWS mla01.
Comment 8 Marcus 2009-12-08 16:51:08 UTC
closed