This triviality fixes the build (upto the end of helpcontent2). Of course it
doesn't then run lucene.

--- helpcontent2/util/target.pmk	30 Jun 2008 11:44:54 -0000	1.23
+++ helpcontent2/util/target.pmk	1 Jul 2008 02:49:13 -0000
@@ -40,4 +40,6 @@
  
 $(LINKALLTARGETS) : $(foreach,i,$(LINKLINKFILES)
$(COMMONMISC)$/$$(@:b:s/_/./:e:s/.//)/$i)
$(subst,LANGUAGE,$$(@:b:s/_/./:e:s/.//) $(LINKADDEDDEPS))
$(COMMONMISC)$/xhp_changed.flag $(PRJ)$/helpers$/hid.lst
 	$(WRAPCMD) HelpLinker @$(mktmp -mod $(LINKNAME) -hid $(PRJ)$/helpers/hid.lst
-src $(COMMONMISC) -sty $(PRJ)$/source$/auxiliary$/embed.xsl -zipdir
$(MISC)$/ziptmp$(@:b) -idxcaption $(PRJ)$/source$/auxiliary$/idxcaption.xsl
-idxcontent $(PRJ)$/source$/auxiliary$/idxcontent.xsl -lang
{$(subst,$(LINKNAME)_, $(@:b))} $(subst,LANGUAGE,{$(subst,$(LINKNAME)_, $(@:b))}
$(LINKADDEDFILES)) $(foreach,i,$(LINKLINKFILES)
$(COMMONMISC)$/{$(subst,$(LINKNAME)_, $(@:b))}/$i) -o $@)
+.IF "$(SOLAR_JAVA)" == "YES"
 	$(JAVAI) $(JAVA_LIBRARY_PATH) -cp $(my_cp) com.sun.star.help.HelpIndexer -foo
-mod $(LINKNAME) -zipdir $(MISC)$/ziptmp$(@:b) -o $@
+.ENDIF

ab: does the runtime handle the absence of the files? Or does something else in
the build require those files?

ab->rene: I've just done some tests. Problem is that with omitting the Java call
the complete target zip files like sbasic_en-US.zip etc. are missing afterwards 
as also the zipping is done in this step. This breaks instset_native as these
zip files are expected to exist.

Besides this the help doesn't work at runtime then as not only the lucene rela-
ted help files would be missing but also the other content of theses zip files.
I tried to add a zip command to do the work, but in my tests I always get the
complete path to the ziptmp stored into the zip file instead of only the files
contained in the ziptmp folder. Previously the zipping has been done by a perl
script generated by the HelpLinker.

If i91158 will be fixed as master fix, we should consider to also fix this one
in the same scope.

> ab->rene: I've just done some tests. Problem is that with omitting > the Java call
> the complete target zip files like sbasic_en-US.zip etc. are
> missing afterwards 
> as also the zipping is done in this step. This breaks
> instset_native as these
> zip files are expected to exist.

Yeah, I let my build continue over night and I just saw that, too when waking up :-(

> Besides this the help doesn't work at runtime then as not only
> the lucene rela-
> ted help files would be missing but also the other content of
> theses zip files.

Yeah. But let's assume only the lucene-related files won't be there (and the
other problem fixed). Would it then work still?
That should be made work.

> I tried to add a zip command to do the work, but in my tests I > always get the
> complete path to the ziptmp stored into the zip file instead of
> only the files
> contained in the ziptmp folder. Previously the zipping has been
> done by a perl
> script generated by the HelpLinker.

And why not use that script in the SOLAR_JAVA != YES case?

> If i91158 will be fixed as master fix

m22 already is labelled ready..

> Yeah. But let's assume only the lucene-related files won't be there (and the
> other problem fixed). Would it then work still?
> That should be made work.

Then everything should work, but of course the help search, as this
is the functionality the index is needed for. But the Office won't
crash and I see no further problems.


>> contained in the ziptmp folder. Previously the zipping has been
>> done by a perl script generated by the HelpLinker.

> And why not use that script in the SOLAR_JAVA != YES case?

The generation of this temporary file has been removed from the
helplinker code. Of course it could be readded but then we also
needed a special option for !Java to be passed to HelpLinker.
Sounds not too nice for me, but if I don't find another solu-
tion I will do it like this.

cws ab55 is currently created for this issue and i91158.

Looks as if

+.IF "$(SOLAR_JAVA)" == "YES"
       $(JAVAI) $(JAVA_LIBRARY_PATH) -cp $(my_cp) com.sun.star.help.HelpIndexer -foo
-mod $(LINKNAME) -zipdir $(MISC)$/ziptmp$(@:b) -o $@
+.ELSE
+      $(RM) $(MISC)$/ziptmp$(@:b)$/content/*.*
+      $(RM) $(MISC)$/ziptmp$(@:b)$/caption/*.*
+      zip -j -D $@ $(MISC)$/ziptmp$(@:b)$/*
+      $(RM) $(MISC)$/ziptmp$(@:b)$/*.*
+.ENDIF

will do the job. As discussed with hjs it leaves some temporary folders 
in $(MISC), because $(RM) -rf better shouldn't be used. This will be 
fixed in a follow up issue for hjs to provide something like $(RMDIR).

Then the target zip files are build containing everything but the
Lucene index. I will do a test build over night.

It has to be == "TRUE" instead of == "YES" and -$(RM) instead of $(RM)
as the folders can be empty and "no match" shouldn't break the build.
Tested that an Office packed with the zip files not containing the index
runs including the help. Searching in help gives no result then.
-> FIXED

$(RMDIR): #i91379

.

This issue is closed automatically and wasn't rechecked in a current version of
OOo. The fixed issue should be integrated in OOo since more than half a year. If
you think this issue isn't fixed in a current version (OOo 3.1), please reopen
it and change the field 'Target Milestone' accordingly.

If you want to download a current version of OOo =>
http://download.openoffice.org/index.html
If you want to know more about the handling of fixed/verified issues =>
http://wiki.services.openoffice.org/wiki/Handle_fixed_verified_issues